feat: Support for storing passkeys in the vault #3593

GeekCornerGH · 2023-06-19T07:37:11Z

Implements the ability to store passkeys in the vault

How to test

Checkout this branch, then install dependencies with npm i (npm ci didn't worked, where npm i somehow worked in my case)
Enable feature flag for the extension. As I didn't figured out how to do this properly, I changed the values there and there to make them always return true
Follow the docs to build and install the modified extension in your browser (I installed it in a custom profile)
Go to a website supporting passkeys. I used passkeys.io, and also tested against webauthn.io but any website supporting webauthn should actually work, then register your key

Demo

0t3iC11yBS.mp4

Notes

Upstream PR: bitwarden/server#2679
Tested on Brave 1.54.65 Chromium: 114.0.5735.133 (Official build) nightly (64 bits)
The feature isn't released yet, but there shouldn't be any big changes as Vaultwarden doesn't type the properties of ciphers the way upstream server does

meowcoder · 2023-10-09T18:22:41Z

Enable feature flag for the extension. As I didn't figured out how to do this properly

The extension queries the /api/config endpoint for this.
One can enable passkeys like this:

diff --git a/src/api/core/mod.rs b/src/api/core/mod.rs
index f142468..2e50870 100644
--- a/src/api/core/mod.rs
+++ b/src/api/core/mod.rs
@@ -200,6 +200,9 @@ fn config() -> Json<Value> {
           "name": "Vaultwarden",
           "url": "https://github.com/dani-garcia/vaultwarden"
         },
+        "featureStates": {
+            "fido2-vault-credentials": true
+        },
         "environment": {
           "vault": domain,
           "api": format!("{domain}/api"),

stefan0xC · 2023-10-09T19:15:05Z

@meowcoder I don't think that's enough because this feature has not even been merged yet upstream. See bitwarden/server#2679 and bitwarden/clients#4715

And because Bitwarden has changed their passkey implementation from it's own item type to a login item field (c.f. bitwarden/server#3261) we also have to update our implementation as well.

In general, I don't think that we should enable features before they are stable.

ItsShadowCone · 2023-11-01T08:41:56Z

Upstream support has been released, so should be stable now: see #3355

What's necessary to get there for vaultwarden too?

agelwarg · 2023-11-02T22:56:43Z

Upstream support has been released, so should be stable now: see #3355

What's necessary to get there for vaultwarden too?

Also looks like the updates to the clients / browser extensions have been rolled out as well (just updated on my iPhone) and it works (against upstream, not Vaultwarden).

GeekCornerGH · 2023-11-03T14:11:06Z

Working on a new PR

adriy-be · 2023-11-04T11:45:38Z

I retried today and that work now. Thanks for your work ! 😁

Hi, I have updated my docker file to testing tag. But It's not working on brave.
There is diagnostics of vaultwarden:
Server Installed: 1.29.2-93da5091
Server Latest: 1.29.2-93da5091
Web Installed: 2023.10.0

And my extension:
version : 2023.10.0
Server version: 1.29.2

Brave version:
[Version 1.60.110 Chromium: 119.0.6045.105 (Official Build) (64-bit)]

The message I have got when I try:

dani-garcia approved these changes Jun 22, 2023

View reviewed changes

feat: Support for storing passkeys in the vault

1074315

GeekCornerGH force-pushed the feature/store-passkeys-in-the-vault branch from eb7dcb0 to 1074315 Compare June 22, 2023 16:49

GeekCornerGH requested a review from dani-garcia June 22, 2023 16:49

dani-garcia approved these changes Jun 22, 2023

View reviewed changes

dani-garcia merged commit e7f083d into dani-garcia:main Jun 22, 2023

GeekCornerGH mentioned this pull request Nov 3, 2023

feat: Working passkeys storage #4025

Merged

chii-bot bot mentioned this pull request Oct 13, 2024

feat(container): update image docker.io/vaultwarden/server to v1.32.5 toboshii/home-ops#796

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Support for storing passkeys in the vault #3593

feat: Support for storing passkeys in the vault #3593

GeekCornerGH commented Jun 19, 2023 •

edited

Loading

meowcoder commented Oct 9, 2023

stefan0xC commented Oct 9, 2023 •

edited

Loading

ItsShadowCone commented Nov 1, 2023

agelwarg commented Nov 2, 2023 •

edited

Loading

GeekCornerGH commented Nov 3, 2023 •

edited

Loading

adriy-be commented Nov 4, 2023 •

edited

Loading

feat: Support for storing passkeys in the vault #3593

feat: Support for storing passkeys in the vault #3593

Conversation

GeekCornerGH commented Jun 19, 2023 • edited Loading

Implements the ability to store passkeys in the vault

How to test

Demo

Notes

meowcoder commented Oct 9, 2023

stefan0xC commented Oct 9, 2023 • edited Loading

ItsShadowCone commented Nov 1, 2023

agelwarg commented Nov 2, 2023 • edited Loading

GeekCornerGH commented Nov 3, 2023 • edited Loading

adriy-be commented Nov 4, 2023 • edited Loading

GeekCornerGH commented Jun 19, 2023 •

edited

Loading

stefan0xC commented Oct 9, 2023 •

edited

Loading

agelwarg commented Nov 2, 2023 •

edited

Loading

GeekCornerGH commented Nov 3, 2023 •

edited

Loading

adriy-be commented Nov 4, 2023 •

edited

Loading